----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63303/#review189302 -----------------------------------------------------------
Trivial nit - put a space before "=" here: public static final String COMPONENT_TYPE= "sentry.provider.backend.generic.component-type"; Apart from that it looks fine to me. - Colm O hEigeartaigh On Oct. 25, 2017, 7:01 p.m., Mano Kovacs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63303/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 7:01 p.m.) > > > Review request for sentry and Sergio Pena. > > > Bugs: SENTRY-1992 > https://issues.apache.org/jira/browse/SENTRY-1992 > > > Repository: sentry > > > Description > ------- > > Adding external configuration options for SentryGenericProviderBackend to > specify component and serviceName without informing the binding. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java > 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 280aebc844a42c056214d39c0be7b8a42bce6ab1 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63303/diff/1/ > > > Testing > ------- > > > Thanks, > > Mano Kovacs > >
