-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63509/
-----------------------------------------------------------
(Updated Nov. 3, 2017, 10:52 p.m.)
Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, and Sergio
Pena.
Bugs: SENTRY-2028
https://issues.apache.org/jira/browse/SENTRY-2028
Repository: sentry
Description
-------
With the current default datanucleus configuration, datanucleus tries to update
the database schema. This is not desired as the schema creation and update
happens from schemaTool using sql files.
This is a problem regardless of the datanucleus version. Issues with this
configuration are exposed with oracle database. we have not tested the upstream
code with this oracle backend database. when I started using oracle database we
saw couple of issues and the root cause for that was datanucleus trying to
create schema.
With this change, issues reported in SENTRY-1934 and SENTRY-2011 will not be
seen. I feel we should revert code changes done for these jira's
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
0cd6e48aa1a6a8b4a5b63c5f156c7a633fb6c509
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
8dd54978d4a78f688ee7e41a2b9eaf1a43e9f50c
Diff: https://reviews.apache.org/r/63509/diff/1/
Testing (updated)
-------
Made sure that unit tests pass.
Thanks,
kalyan kumar kalvagadda
