----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/#review190431 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java Lines 3469 (patched) <https://reviews.apache.org/r/63645/#comment267763> While this may be a useful test, it is better to write specific unit test for the String manipulation functions directly. - Alexander Kolbasov On Nov. 7, 2017, 9:16 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63645/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 9:16 p.m.) > > > Review request for sentry, Sergio Pena and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > When retrieving full path image update, we split a path by "/" and create HMS > Path entries. However, the leading "/" presence will cause issues because on > splitting the value at index 0 will be empty. This will affect the creation > of HMS path entries. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java > cef8bd734 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > cf83e7796 > > > Diff: https://reviews.apache.org/r/63645/diff/1/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore > > > Thanks, > > Arjun Mishra > >
