----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63619/#review190493 -----------------------------------------------------------
Ship it! Ship It! - Na Li On Nov. 7, 2017, 6:17 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63619/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 6:17 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2033 > https://issues.apache.org/jira/browse/SENTRY-2033 > > > Repository: sentry > > > Description > ------- > > TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to > get the updates on the changes in HMS data. SentryMetastorePostEventListener > is obsolete, and the tests should not use it any more.Tests should use > implementations of MetaStoreEventListener to process the notifications. > > Here is the summary of code changes done: > 1. Change the base class from AbstractTestWithStaticConfiguration to > TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not > creae/start HMS service. > 2. Made code changes to update property "sentry.hive.server" > 3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for > TestHDFSIntegrationBase. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > 33c91244af40fabb9eca246a7664bed345e3c9f3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694 > > > Diff: https://reviews.apache.org/r/63619/diff/2/ > > > Testing > ------- > > Made sure that the tests pass > > > Thanks, > > kalyan kumar kalvagadda > >
