----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63775/#review191083 -----------------------------------------------------------
The subject of the review board must match the JIRA subject. You could either change the JIRA or the Review subject to match the correct fix. The getUniqueMSentryPrivilege() is still confusing. Any idea of the difference in both methods? Seems getMSentryPrivileges() lacks of the grant option and unique query. The unique query is used to avoid datanucleus to return a list, so this is ok, but how does the grant option being the only difference between a list and a single privilege? - Sergio Pena On Nov. 13, 2017, 11:11 p.m., Steve Moist wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63775/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 11:11 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1543 > https://issues.apache.org/jira/browse/SENTRY-1543 > > > Repository: sentry > > > Description > ------- > > Renamed methods to be more clear in their use since they both have the same > name but function and query differently. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7217dea7 > > > Diff: https://reviews.apache.org/r/63775/diff/1/ > > > Testing > ------- > > Unit tests ran. > > > Thanks, > > Steve Moist > >
