> On Nov. 14, 2017, 8:19 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java > > Lines 116-117 (original), 116-122 (patched) > > <https://reviews.apache.org/r/63402/diff/1/?file=1872582#file1872582line116> > > > > I think this requires a special function instead ofu sing > > appendConfVar(). > > > > I was reading more about this ACL configuration and I learned that it > > can also use the "*" value. In this patch, the new value would be > > "user1,*", right? Would that work? * already implies that ALL users and > > groups are allowed, so there is no reason to modify it, right? > > > > What about writing a new private function to append new user > > information only and handle those cases? > > Sergio Pena wrote: > Weird, when you see the empty quotes, I meant to add an asterisk, but the > review board removed it.
Implemented the comments: - used a private function to update setting - handle wildcard ACL - trimmed the ACL when done which allowed the test change to be rolled back - updated the HiveAuthzBindingSessionHookV2 also because it had the same problem - Wilfred ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63402/#review190997 ----------------------------------------------------------- On Nov. 15, 2017, 9:02 p.m., Wilfred Spiegelenburg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63402/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 9:02 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2021 > https://issues.apache.org/jira/browse/SENTRY-2021 > > > Repository: sentry > > > Description > ------- > > Allow MR session ACLs to start with a space or end in a space. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java > 7250891 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > 02ac514 > > > Diff: https://reviews.apache.org/r/63402/diff/1/ > > > Testing > ------- > > local run junit test and e2e automated testing through build > > > File Attachments > ---------------- > > SENTRY-2021.003.patch > > https://reviews.apache.org/media/uploaded/files/2017/10/31/1b8e6eec-9e95-47f6-bcb7-4b5d7a4ffd57__SENTRY-2021.003.patch > SENTRY-2021.005.patch > > https://reviews.apache.org/media/uploaded/files/2017/11/15/45849e2b-e7a0-4d6a-93b5-c198a3095ed5__SENTRY-2021.005.patch > > > Thanks, > > Wilfred Spiegelenburg > >
