> On Nov. 17, 2017, 5:31 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > > Line 144 (original), 141 (patched) > > <https://reviews.apache.org/r/63896/diff/1/?file=1895951#file1895951line146> > > > > With the change same sentry store will be used for all the tests. > > Please document the change so tha people adding tests this class are aware > > of this.
Other tests do not document this, what's special to document this here? SentryStore is just an interface used to access the DB (devs should know this, don't they)? - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63896/#review191364 ----------------------------------------------------------- On Nov. 17, 2017, 12:08 a.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63896/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 12:08 a.m.) > > > Review request for sentry. > > > Bugs: sentry-2052 > https://issues.apache.org/jira/browse/sentry-2052 > > > Repository: sentry > > > Description > ------- > > This patch has a couple of improvements: > * Set the transaction retry max to 1 instead of 10. This high number was > causing much of the overhead on the tests. I could not set to 0 because the > TestSentryStore takes more time for some reason. > * Moved the SentryStore object creation from the @Before method to the > @BeforeClass method. This also save precious 35 seconds. > > With the patch the time is reduced from 3min to 45 seconds. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > cf83e7796fd5bc22c76cba6096b0a821e82b87a7 > > > Diff: https://reviews.apache.org/r/63896/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
