----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63996/#review191631 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java Line 589 (original), 589 (patched) <https://reviews.apache.org/r/63996/#comment269474> Can you add comment on why it should be transactional event listener? - Na Li On Nov. 21, 2017, 6:34 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63996/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 6:34 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2059 > https://issues.apache.org/jira/browse/SENTRY-2059 > > > Repository: sentry > > > Description > ------- > > Currently DbNotificationListener and > SentryMetastorePostEventListenerNotificationLog are using not configured as > transactional listeners. They should be configured as transactional listeners. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 25a678b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > a6e7356 > > > Diff: https://reviews.apache.org/r/63996/diff/1/ > > > Testing > ------- > > Made sure all the unit and e2e tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
