> On Nov. 21, 2017, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 257 (patched) > > <https://reviews.apache.org/r/63993/diff/3/?file=1898893#file1898893line257> > > > > the logging level can be info to be consistent with another logging > > level.
Sergio brought up a good point where if the Sentry service was started and no DDL or DML queries are being executed, then MAuthzPathsSnapshotId table will still be empty, because we will be fetching empty notificaitons. In that case a INFO level log can result in spamming. - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63993/#review191640 ----------------------------------------------------------- On Nov. 21, 2017, 7:56 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63993/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 7:56 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and > Vadim Spector. > > > Repository: sentry > > > Description > ------- > > AUTHZ_PATHS_SNAPSHOT_ID is only populated when a full HMS snapshot is > persisted. When initially HDFS Sync is disabled, we will create a full > snapshot but never persist it, and at the same time populate > SENTRY_HMS_NOTIFICATION_ID table. Later when HDFS sync is enabled, a full > snapshot will not occur unless until HMS and Sentry are out of sync. This > will result in ACL's not being applied unless until HMS and Sentry are out of > sync, since we only send NN snapshots if AUTHZ_PATHS_SNAPSHOT_ID has values > greater than 0 > We should create a full snapshot if hdfsSync is enabled, and > AUTHZ_PATHS_SNAPSHOT_ID is empty > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 4dc2bf6d1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > c4cc91806 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > bbcf09382 > > > Diff: https://reviews.apache.org/r/63993/diff/3/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > Second patch: > mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestHMSFollower > > > File Attachments > ---------------- > > SENTRY-2046.04.patch > > https://reviews.apache.org/media/uploaded/files/2017/11/21/c86539e8-54bd-4b73-8e4d-62512520d4a1__SENTRY-2046.04.patch > > > Thanks, > > Arjun Mishra > >
