> On Nov. 20, 2017, 11:43 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > > Lines 52-54 (patched) > > <https://reviews.apache.org/r/63958/diff/1/?file=1897755#file1897755line52> > > > > Can we configure these properties in the same way other properties done > > by using global variables instead? This abstract test class needs some > > redesign and I don't like global variables, but to keep the configuration > > consistent, can we do it for these? > > > > Or, why aren't they just set by defalut on the TestHDFIntegrationBase?
sentryProperties contains several global properties. It is cleaner to keep them contained in sentryProperties instead of having bunch of global variables. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63958/#review191546 ----------------------------------------------------------- On Nov. 21, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63958/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 12:27 a.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2034 > https://issues.apache.org/jira/browse/SENTRY-2034 > > > Repository: sentry > > > Description > ------- > > Currently, there are no e2e tests that test the functionality of pulling the > notifications from HMS and processing them. Which include updating the update > the permissions based on the HMS updates. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > 2138304 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java > 33ace57 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 25a678b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > 645fc35 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > a911e2f > > > Diff: https://reviews.apache.org/r/63958/diff/2/ > > > Testing > ------- > > Made sure that new tests added and all the older tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
