> On Nov. 30, 2017, 2:58 a.m., Na Li wrote: > > sentry-provider/sentry-provider-db/pom.xml > > Lines 230 (patched) > > <https://reviews.apache.org/r/64179/diff/1/?file=1904065#file1904065line230> > > > > do you need to add this in both root pom.xml line 635 and here?
It's not necessary. Tihs is only used by the sentry service which is part of the sentry-provider-db module - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64179/#review192228 ----------------------------------------------------------- On Nov. 29, 2017, 10:37 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64179/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 10:37 p.m.) > > > Review request for sentry. > > > Bugs: sentry-2079 > https://issues.apache.org/jira/browse/sentry-2079 > > > Repository: sentry > > > Description > ------- > > This patch excludes other curator dependencies that do conflict with Sentry > curator dependencies. > It also shade the curator deps to avoid other components dealing with curator > to conflict with Sentry curator. > > This patch is necessary to make Sentry HA mode work again. > > > Diffs > ----- > > pom.xml 63adf66861436833a282c126670ef61e30a7672a > sentry-binding/sentry-binding-solr/pom.xml > 0db76bb50ac8a9714d6ecb280ad8449d1c3b5d3e > sentry-provider/sentry-provider-db/pom.xml > d4fd9bd780071fcad72b5c5be77a454d329bdca3 > sentry-tests/sentry-tests-solr/pom.xml > c7125bd40723f626558c9203195f9d2e009b636a > > > Diff: https://reviews.apache.org/r/64179/diff/1/ > > > Testing > ------- > > I configured Sentry HA with this patch and is working. > > > Thanks, > > Sergio Pena > >
