----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/#review192558 -----------------------------------------------------------
LICENSE.txt Line 214 (original) <https://reviews.apache.org/r/64241/#comment270795> Should theLICENSE.txt include copyrights as well or not? Looks like you are removing some copyrights. README_license.txt Lines 9 (patched) <https://reviews.apache.org/r/64241/#comment270826> s/in places/in place README_license.txt Lines 10 (patched) <https://reviews.apache.org/r/64241/#comment270827> s/build/built README_license.txt Lines 11 (patched) <https://reviews.apache.org/r/64241/#comment270828> Does it run during every build or it should be manually invoked? README_license.txt Lines 12 (patched) <https://reviews.apache.org/r/64241/#comment270829> Before you say 'we' and here it is 'you'. Please be consistent README_license.txt Lines 14 (patched) <https://reviews.apache.org/r/64241/#comment270830> I think third party is two words. Also this doesn't look like an item from enumeration, just the description text, so this should be moved to the top level paragraph. README_license.txt Lines 16 (patched) <https://reviews.apache.org/r/64241/#comment270831> with licenses listed below README_license.txt Lines 34 (patched) <https://reviews.apache.org/r/64241/#comment270832> Is there anything that checks correctness of pointers? What would happen if release manager forgets to add the file? pom.xml Lines 734 (patched) <https://reviews.apache.org/r/64241/#comment270821> This looks like an unrelated change - can you move this to a different JIRA? - Alexander Kolbasov On Dec. 1, 2017, 9:29 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64241/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 9:29 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O > hEigeartaigh, and Sergio Pena. > > > Bugs: SENTRY-2081 > https://issues.apache.org/jira/browse/SENTRY-2081 > > > Repository: sentry > > > Description > ------- > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. > > > Diffs > ----- > > LICENSE.txt b794ae6604774186020a1cf3dde922e92da57276 > README_license.txt PRE-CREATION > pom.xml eec185bc6409e5cebee12f3a0e4ca17c843cd631 > sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 > sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION > sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION > sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION > sentry-dist/src/main/assembly/bin.xml > 5727fc964bc139a5bd5490132efad13db6cbcf44 > sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION > sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION > sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION > > sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt > PRE-CREATION > sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION > > sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt > PRE-CREATION > sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64241/diff/7/ > > > Testing > ------- > > Made sure that LICENSE.txt file generated in sentry-dist/target directory has > the license informaion of all the jars that sentry is distributing. > > > Thanks, > > kalyan kumar kalvagadda > >
