----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63596/#review193478 -----------------------------------------------------------
Ship it! Ship It! sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java Line 57 (original), 56 (patched) <https://reviews.apache.org/r/63596/#comment272035> Not necessarily as part of this fix it would be great to have tesst that not only check counts but actually verify the content of the returned values. - Alexander Kolbasov On Dec. 11, 2017, 9:02 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63596/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2017, 9:02 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, Na > Li, Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > The old retrieveFullPathsImage() method in SentryStore is no longer used by > actual code (retrieveFullPathsImageUpdate(final String[] prefixes) is used > instead. It was preserved because it is used by test which now doesn't make > much sense. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > b355630e7 > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java > f09d1b228 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > c730a03a5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 24b11f724 > > > Diff: https://reviews.apache.org/r/63596/diff/6/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore > mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test > -Dtest=TestSentryHDFSServiceProcessor > mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test > -Dtest=TestImageRetriever.java > > > Thanks, > > Arjun Mishra > >
