-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64960/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio
Pena, and Vadim Spector.
Bugs: SENTRY-2113
https://issues.apache.org/jira/browse/SENTRY-2113
Repository: sentry
Description
-------
Here is the description of code changes done
1. Made code changes to sql scripts to have notificaiton has in
SENTRY_HMS_NOTIFICATION_ID table with unique index.
2. Made JDO changes to have notification has in MSentryHmsNotification
3. Added additional logging which will be helpfull in debugging.
4. Code changes to persist notification has along with event-id in
SENTRY_HMS_NOTIFICATION_ID table.
5. Lookup MSentryHmsNotification to know if the notification is processed
instead of using MSentryPathChange.
6. Avoid looking for MSentryHmsNotification to descide if snapshot is needed.
As this is not correct. If there are no notifications after a snapshot is taken
there will be full snpashots taken again and again. Instead i changes it to use
Path Mapping information.
7. Fixed the tests
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UniquePathsUpdate.java
38b4e2a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
34180e7
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
d883c51
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java
849e5f8
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
6c4631f
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
aa1b6a3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java
097aa62
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java
d09da5f
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
477d224
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql
33e36c7
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql
db66b13
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql
2746922
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql
69d8a24
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql
6c55d28
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql
df34f87
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql
6526ab2
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql
25f3356
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.8.0-to-2.0.0.sql
cf5a450
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
b410027
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java
edde886
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java
964a56c
Diff: https://reviews.apache.org/r/64960/diff/1/
Testing
-------
Made sure all the tests are passing.
Thanks,
kalyan kumar kalvagadda
