----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64955/ -----------------------------------------------------------
(Updated Jan. 5, 2018, 12:10 a.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio Pena, and Vadim Spector. Changes ------- addressed review comments from vadim Bugs: SENTRY-2109 https://issues.apache.org/jira/browse/SENTRY-2109 Repository: sentry Description ------- This patch does couple of things 1. Avoid triggering full snapshots when gaps are observed while fetching new notifications. While fetching new notifications HMSFollower would would fetch notifications with last event-id as well. When it gets the notifications and if it doesn't get the notifications with event-id, full snpshot is triggered. 2. Added looging to report duplicate events and out of order events for debug purpose. 3. Added new e2e tests to verfy this behavior. Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryOutOfSyncException.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 6c4631fa74760d8721b5740dd3dffb2c1d8e72e6 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java aa1b6a31c28f35af86952c213d5e20a8c9bb3490 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java 097aa62912e92ece7f8da0ac0fccb124579a88f2 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 43535a7b50fea51049f3142837736e6a99a3a80f sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 501898bca261db2daf937a8d803d12a59616192b sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java b4100278392986c161625a366212c6fef66ec0a9 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java edde886a7646539499149f2d86758979436567bd sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestSnapshotCreation.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestSnapshotCreationWithShorterHMSEventTtl.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestSnapshotWithLongerHMSFollowerLongerInterval.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba Diff: https://reviews.apache.org/r/64955/diff/2/ Changes: https://reviews.apache.org/r/64955/diff/1-2/ Testing ------- Made sure that tests pass. There are three test failures which need code change done for SENTRY-2113. Thanks, kalyan kumar kalvagadda