> On Jan. 4, 2018, 10:19 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java > > Lines 199 (patched) > > <https://reviews.apache.org/r/64949/diff/1/?file=1930458#file1930458line199> > > > > Shouldn't we throw a checked exception instead of RuntimeException? > > Also, can we add an error message about what the user should do in case a > > login error happens? perhaps specify that they need to use X and Y > > configuration variables for the keryba and principal?
Well, I assume the original intent of this wrapping was to hide the internal errors from the upstream APIs. I think the proper stacktrace would be more the sufficient here as it would complain about the exact file the user was configuring. - Mano ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/#review194781 ----------------------------------------------------------- On Jan. 6, 2018, 9:31 p.m., Mano Kovacs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64949/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2018, 9:31 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-641 > https://issues.apache.org/jira/browse/SENTRY-641 > > > Repository: sentry > > > Description > ------- > > Binding for Lily Hbase Indexer, based on the implementation Gregory Chanan > created for CDH version of Sentry. The patch contains implementation that has > no dependency to Lily. > > > Diffs > ----- > > pom.xml c797181c8f123bc914ece27c13b70540978091bc > sentry-binding/pom.xml b12683c1c742c989ac118e968c71df50366a8557 > sentry-binding/sentry-binding-hbase-indexer/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/conf/HBaseIndexerAuthzConf.java > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/test/java/org/apache/sentry/binding/hbaseindexer/TestHBaseIndexerAuthzBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/test/resources/log4j.properties > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/test/resources/sentry-site-service.xml > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/test/resources/sentry-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-hbase-indexer/src/test/resources/test-authz-provider.ini > PRE-CREATION > sentry-dist/pom.xml 63eb81c87172dc3237039b6d7641881b2831079f > sentry-dist/src/license/THIRD-PARTY.properties > 22429fc3d644ea961d59260b4a08eb380d7a4325 > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java > 9e9a0d2b3afc22098980b5a54b6a9989ad035b6f > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > 5dc2b5592bdfbb281b083bdc835d455d07df0d86 > > > Diff: https://reviews.apache.org/r/64949/diff/2/ > > > Testing > ------- > > > Thanks, > > Mano Kovacs > >
