----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/ -----------------------------------------------------------
(Updated Jan. 29, 2018, 9:34 p.m.) Review request for sentry, Arjun Mishra, Na Li, Sergio Pena, and Vadim Spector. Changes ------- Addressed review comments. Bugs: SENTRY-1904 https://issues.apache.org/jira/browse/SENTRY-1904 Repository: sentry Description ------- The TransactionManager uses exponential backoff strategy for transaction retries. This may cause some transactions to be delayed by a very long time. We should also have a constraint on the max time for a transaction so that we do not retry for too long. New patch that is attached adds upper bounds on below 1.Interval between the retry attempts which increases exponentially. 2.Total time a transaction could spend in retries. With out these limits we would not have a control on how long a transaction could be be active. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java 2f2b984 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java f4ff962 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 7e02874 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 91c90f9 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java b410027 Diff: https://reviews.apache.org/r/65268/diff/4/ Changes: https://reviews.apache.org/r/65268/diff/3-4/ Testing ------- Made sure all the tests pass. Thanks, kalyan kumar kalvagadda