----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198133 -----------------------------------------------------------
Does the test show the problem before the fix? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java Line 96 (original), 98 (patched) <https://reviews.apache.org/r/65704/#comment278245> Is there any benefit in creating separate function that is only used here? Why not just inline the code? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java Lines 146 (patched) <https://reviews.apache.org/r/65704/#comment278246> Please remove all this logging. This whole thing can be simplified to `return !newDbName.equalsIgnoreCase(oldDbName) || !newTableName.equalsIgnoreCase(oldTableName);` You don't need this if statement at all. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2412-2413 (patched) <https://reviews.apache.org/r/65704/#comment278247> What does this have to do with the JIRA that you are fixing? Looks like some kinnd of separate issue. - Alexander Kolbasov On Feb. 22, 2018, 6:55 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65704/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 6:55 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > wait for HMS sync at alter table, which including table rename and changing > table columns > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > 24d7763 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7a31a01 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > 5fe6625 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 9b0aeb2 > > > Diff: https://reviews.apache.org/r/65704/diff/4/ > > > Testing > ------- > > unit tests succeeded > > > Thanks, > > Na Li > >
