-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66360/
-----------------------------------------------------------
(Updated April 10, 2018, 2:16 p.m.)
Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio
Pena.
Changes
-------
Updated new patch which has changed to pom file avoiding the date added to the
thrift files that are generated.
Changes in the rest of the thrift generated files is just date. Date is removed
from all of them.
Bugs: SENTRY-2192
https://issues.apache.org/jira/browse/SENTRY-2192
Repository: sentry
Description
-------
With the current thrift options used, @Generated annotation adds date which
kind of updates all the thrift generated files when --thriftif option used.
When someone makes some changes to any of the thrift definitions and tries to
generate the source all the auto generated files get updated.
This can be avoided by suppressing date in the @generated annotation.
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/pom.xml
5c6c96c46ee384ba5981611333741fde3bd59e10
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java
726337c39283304166f13999b5e9f8a82f5219b4
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java
b61d5b6041228b6aa530c53c97f1c910d46e6943
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java
f837e47ca9eec88ca4209ab0cdbe5da70d840acb
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java
bf10bf0fcc42d1af8f2789259bfb638918b3eede
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java
4bed8d675d2aaac2567e15ad4b41e5daaa8940aa
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java
b37c8bea2e076f51121262d7113e8d1f76fa0464
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java
2ce52a7a0453c4f8725909ca3604fa18f4d94c99
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java
3d90816bcaf3f592f7a9fbd9a8293f312b71e1da
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java
ed2f6fa19bf5b0552454dbfbde24d25e02340643
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java
e5bd36d5f1f6eb362584bcce386d7cd39bc43d23
sentry-provider/sentry-provider-db/pom.xml
4751549bcc40d60ca8f5400dd371761bc6fbf2d5
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java
cb75cf2680fbb924502d95c43eaa876e29a1f799
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java
a97571d14464dd012b5ab5f8c2d929c9d81213b5
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java
159f61ac80fd626a338ec0aa1a1e8a17e0505097
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java
1578bea61d095cf27b32da987c17f38a9c09a1e4
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java
c74773c37e0708b13b35c40a7c3a07a1a811508a
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java
a9c89e5d93c7fc59afa16f8d5411d62ff83fb70b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java
9bf736cf39bcf62e9cdd8ac4b5b1f01f0f51be6d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java
a03c2aa1d0e6ca273961a49ca165a1e95d4d0b58
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java
96436c0613b864c7374f97027865cd652117992b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAuthorizable.java
b6cfe5d334e7ddb47c94e4c456d44691be509bf6
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java
d0d54e4d7da66902a73be5ece7fffd0c9ddef71d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleResponse.java
483566b9aef8e135cbbdbaef6d6b44f829a2b288
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesRequest.java
759cf0b24e7a924b767255306dce6b759b0ffe88
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropPrivilegesResponse.java
553dbcb57db2a780a935de871ce5f5932362f2b7
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleRequest.java
238a5fb02b1b8f09adab437b1148f9a186c6d78e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TDropSentryRoleResponse.java
d09989d74727ec8efa94cb5bc3bd56f306930c47
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthRequest.java
f7b0ad69265be7c526a71bc87dc4fb9d77b9c955
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthResponse.java
5a02e3db79d6e2b9f0b028861c74b4b287120cee
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderRequest.java
bbf8ea3aaa62fb5aa053ff470220e6cea1653bc2
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesForProviderResponse.java
cd80df823c5434ad80fa23de078c572557694117
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesRequest.java
75c3a1ccda797b9ea75e640ab9793dd80543a10e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesResponse.java
0ad5b4b332bcee81015daa8633b5ddfe5a6b6f4a
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesRequest.java
c49120df38fa3e9cb0539d1296fb03b071f82efe
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryRolesResponse.java
6911c6354555ae740c1200be51269ddac32e6306
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesRequest.java
1d1d966f89d9475ade77252c1ab3018679138627
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TRenamePrivilegesResponse.java
efae0a24ef6d379b4c4ac35ae67e6e6ea7e30572
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryActiveRoleSet.java
656d8333ee45636681e709497464f678b9bc062d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilege.java
c61759fbb47adbcbc5ed8310516a37cc0a7d54fe
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilegeMap.java
b7e5416b80a6f304262454f54a66a65bf1f8b7cd
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryRole.java
30b68f0cf02deff1eec49426017e7f8d9e4cd8f1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java
e25186a83c8b0f9ad9c955f2dbd98fd5a336ed0c
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java
73703d91b776e36fec60dfbe4c5991f2d7afad04
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsResponse.java
9165d492bf6f5bebc34a0954397436ef47eab3a0
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddUsersRequest.java
9e14c1e8f1b10474b97c25bbb312b76d6c13f12d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddUsersResponse.java
030757bc5ca0e458808b1330b251686db8a7a4fc
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java
1fc30791a34aa06e52b1045bddfa668217e2d0d1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java
54d04eba401908bb742e2ad77fe9e392a2965b2f
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteUsersRequest.java
e69e5323baaa0aeaeeab02dc0061b1895c95cf40
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteUsersResponse.java
ee6daf4748ea283c34a625cb6e3b7ba3d706f0c0
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java
6d16d9c4e89f04ed58d25ef3f768dedfc9907ebc
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java
26ba4914074f78b0838ef07238972bcd368cfc8e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java
a72953dabf479604c7dd961248af41ffda6cfbcb
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java
c797133fa799ae7b6e166d938b90684ea2a66071
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java
054ab87b4bbbba10bb82cfd7a6934d84f489d997
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleResponse.java
502d42bab1ab4596b8fd45de91a62d4ed8cced5f
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropPrivilegesRequest.java
b50fd17dbfcf7d54b6ec5a899db3a92f2b522d91
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropPrivilegesResponse.java
408597905f791bc5bc7d9e0c48409a7632900588
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java
20d5e4401bd5dd14fe297a4c970b1ff9ff1ca245
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleResponse.java
a102194e2f0e1f81b786fc9fd5b542515029ea51
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesByAuthRequest.java
4ec2e464c40a57ecede157b83ef16ffc343d4191
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesByAuthResponse.java
b6ee1e095bf6dc498698fc17f9c0fcc868144656
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesForProviderRequest.java
3871e61da95a438298d7a0ad23c1677fd60eaefb
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesForProviderResponse.java
6b7c102f6ebb9f6a16435705493e0c8774efdcd4
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesRequest.java
211cc6aea5b9179014a1a7f84aa6ddc728dec98b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryPrivilegesResponse.java
b81e736ebec56985f28626843409fbbdabcc6953
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesForUserRequest.java
f5ef3b4ffce35e95bfb029d8fe23823d9d128c4d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java
c21703f9d3cc5f4fe30b3762c5526e968edfcc2d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java
cd8fc834283615a364e46f07fe238e89f6d525b2
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TRenamePrivilegesRequest.java
c799ba84187507bcf5529e5028715d45b5092d0d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TRenamePrivilegesResponse.java
577c5c0eb296129b75130b37d8cce36eb1ca5bd5
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryActiveRoleSet.java
b0a98afa1f547735eb011649b33058a339ff9f26
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryAuthorizable.java
03603473e64a0a9b533706b73a49878fb22ffd58
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueRequest.java
57f73db9d1bdcc7120ccecc6d4560df72c14e1f7
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueResponse.java
766bc743a20c4786d109a91a330688bb2460ce70
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java
4a1f27ea3421e631926b572428b0e62117733b4e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataResponse.java
b58118e382455877b60a2020b9c48ce0e8d3120f
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGroup.java
0033516f612d5a253ac95e09623a5a63409e2ee6
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataRequest.java
45193ff4c81df155010eb01698ecc01c2a703404
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataResponse.java
f8b8256244693770b14c57b8230f0bf5a5146e0a
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryMappingData.java
592a47018fbd9232c3871cf845a6f71637b03b5d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java
b27ebe80158bf0654a96d90cfd557401e03d33e1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilegeMap.java
fc01a6a5ffb29abf1ed26e538f9792d13256547e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryRole.java
4150ab8bb2c9312a9c78726c8e223a125f76a337
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentrySyncIDRequest.java
97cfe349d735fd2772f94a599a282beffb4aa44e
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentrySyncIDResponse.java
bc0449dd9bf8c352c663ba876ba92bc344debd60
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/TSentryResponseStatus.java
17c1d7078b55b1dc6b26d4ffe9c5b4f3805246b5
Diff: https://reviews.apache.org/r/66360/diff/2/
Changes: https://reviews.apache.org/r/66360/diff/1-2/
Testing
-------
Made sure all the tests pssed.
Thanks,
kalyan kumar kalvagadda
