----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66337/#review201211 -----------------------------------------------------------
Ship it! Ship It! - Xinran Tinney On March 28, 2018, 4:16 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66337/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 4:16 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2167 > https://issues.apache.org/jira/browse/SENTRY-2167 > > > Repository: sentry > > > Description > ------- > > 1. When the location and name of the object is not changed, sentry ignores > that event. It is not an error. This should be logged with debug level. > > 2. When ever, SentryNoSuchObjectException is thrown, it is logged with INFO > level. It is common that sentry doesn't have permissions on the objects that > are changed. It need not be logged with INFO, instead it should be logged > with debug level. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java > e5ad3b5df5f1fdacd91b18f29394ec8275bb31e1 > > > Diff: https://reviews.apache.org/r/66337/diff/1/ > > > Testing > ------- > > Made sure all the tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
