> On April 13, 2018, 9:13 p.m., Anthony Young-Garner wrote: > > sentry-abac/notes.txt > > Lines 19 (patched) > > <https://reviews.apache.org/r/66590/diff/3/?file=1997972#file1997972line19> > > > > Lines 19 - 20 can be removed if the example-delta.json file is removed.
I just deleted the notes file. > On April 13, 2018, 9:13 p.m., Anthony Young-Garner wrote: > > sentry-abac/pom.xml > > Lines 25 (patched) > > <https://reviews.apache.org/r/66590/diff/3/?file=1997973#file1997973line25> > > > > Should the project version be parameterized? None of the other modules when declaring it's parent are parameterized. > On April 13, 2018, 9:13 p.m., Anthony Young-Garner wrote: > > sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java > > Lines 33 (patched) > > <https://reviews.apache.org/r/66590/diff/3/?file=1997980#file1997980line33> > > > > Add field, getter and setter for descriptor (contentDescriptor). Also > > add a two-arg constructor and update toString, equals and hashCode methods. That's a moderate size change to make at this point, it would be better to include it in another ticket. Especially since we have profiles and actions to include as well. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/#review201127 ----------------------------------------------------------- On April 12, 2018, 8:45 p.m., Steve Moist wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66590/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 8:45 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > This is the inital draft of attribute based access control. > > > Diffs > ----- > > pom.xml 16a3838a > sentry-abac/example-definition.json PRE-CREATION > sentry-abac/example-delta.json PRE-CREATION > sentry-abac/notes.txt PRE-CREATION > sentry-abac/pom.xml PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapAdapter.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMapKeyException.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/GenericAttributeProvider.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/SentryAttributeAuthorizer.java > PRE-CREATION > sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java > PRE-CREATION > > sentry-abac/src/main/java/org/apache/sentry/abac/StaticAttributeProvider.java > PRE-CREATION > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttribute.java > PRE-CREATION > > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java > PRE-CREATION > > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestSentryAttributeAuthorizer.java > PRE-CREATION > > sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java > PRE-CREATION > sentry-abac/src/test/resources/abac.props PRE-CREATION > sentry-binding/sentry-binding-hive/pom.xml ccfa9cfe > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java > 1ab5be35 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java > 86ff0cc2 > > > Diff: https://reviews.apache.org/r/66590/diff/3/ > > > Testing > ------- > > full build,added unit tests, tested code on a cluster. > > > Thanks, > > Steve Moist > >
