-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66748/#review202127
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On April 27, 2018, 3:47 p.m., Steve Moist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66748/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 3:47 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Moved the sentry cli to sentry-tools.  Had to change a dependency in 
> sentry-provider-db to re-use the integration base.
> 
> 
> Diffs
> -----
> 
>   bin/sentryShell 17b1429f 
>   pom.xml 16a3838a 
>   sentry-provider/sentry-provider-db/pom.xml b8cccfa8 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java
>  cf552b16 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java
>  edf09346 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
>  8de543c4 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java
>  e3d81f80 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolSolr.java
>  57999935 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolCommon.java
>  013e824b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolIndexer.java
>  a5996a7b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java
>  1a4692e0 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellGeneric.java
>  4487685a 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellIndexer.java
>  5bbe7727 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/GenericShellCommand.java
>  a792b5cc 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConverter.java
>  0bfbc442 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaHelper.java
>  cf1c7258 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java
>  d75e24bb 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java
>  c8b2eef3 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellHive.java
>  785e27df 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java
>  eeb3a23f 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java
>  3f0b5fad 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/HiveShellCommand.java
>  3abba526 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestPermissionsMigrationToolSolr.java
>  69c067fe 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolIndexer.java
>  4dddf780 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryConfigToolSolr.java
>  9e6ff421 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellIndexer.java
>  f66eb859 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java
>  a9234fa8 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java
>  0f4bb62e 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSqoop.java
>  cdba4420 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java
>  68abf277 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java
>  de8f0433 
>   sentry-provider/sentry-provider-db/src/test/resources/indexer_case.ini  
>   
> sentry-provider/sentry-provider-db/src/test/resources/indexer_config_import_tool.ini
>   
>   sentry-provider/sentry-provider-db/src/test/resources/indexer_invalid.ini  
>   sentry-provider/sentry-provider-db/src/test/resources/solr_case.ini  
>   
> sentry-provider/sentry-provider-db/src/test/resources/solr_config_import_tool.ini
>   
>   sentry-provider/sentry-provider-db/src/test/resources/solr_invalid.ini  
>   sentry-tools/pom.xml 4d8fc89e 
>   sentry-tools/src/main/java/org/apache/sentry/SentryMain.java e92155ce 
>   sentry-tools/src/main/java/org/apache/sentry/shell/GroupShell.java b7652a58 
>   sentry-tools/src/main/java/org/apache/sentry/shell/PrivsShell.java 8b8898fc 
>   sentry-tools/src/main/java/org/apache/sentry/shell/RolesShell.java c014a304 
>   sentry-tools/src/main/java/org/apache/sentry/shell/TopLevelShell.java 
> d9952a99 
>   sentry-tools/src/test/resources/cacerts.jks PRE-CREATION 
>   sentry-tools/src/test/resources/keystore.jks PRE-CREATION 
>   sentry-tools/src/test/resources/log4j.properties PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66748/diff/4/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Steve Moist
> 
>

Reply via email to