----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202279 -----------------------------------------------------------
By isEmpty(), do you mean to exclude URIs that are blank but not empty, such as ALTER TABLE t1 SET LOCATION ' '; Here are the docs for the API I am using. Its for lang version 2.0. In earlier versions, isEmpty() functioned as isBlank(): https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#isEmpty-java.lang.CharSequence- It seems that the code has already determined that getUri() will not return null, so you could also just do privSubjectDesc.getObject().trim().isEmpty() - Ben Iglauer On May 1, 2018, 10:17 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66898/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 10:17 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and > Sergio Pena. > > > Repository: sentry > > > Description > ------- > > We can grant privileges to URI's with EMPTY or NULL locations. This should > not be allowed > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 21a6abf82 > > > Diff: https://reviews.apache.org/r/66898/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
