-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
-----------------------------------------------------------
(Updated May 21, 2018, 4:41 p.m.)
Review request for sentry.
Changes
-------
Added patch 006 because some *.sql files in
sentry-provider-db/src/main/resources were clobbered in the patch.
Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208
Repository: sentry
Description
-------
Refactored the SentryService class and its dependencies from
sentry-provider/sentry-provider-db into a new
sentry-service/sentry-service-server module. In addition, refactored
SentryServiceClientFactory into a new sentry-service/sentry-service-client
module.
Work is based on previously completed work on SENTRY-1205.
NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff
consists of file moves (from sentry-provider-db to sentry-service-server)
https://issues.apache.org/jira/browse/SENTRY-2208
Diffs (updated)
-----
sentry-service/pom.xml 0388476f2e55dbc76262a4b0ddb597b816d8fb15
sentry-service/sentry-service-client/pom.xml PRE-CREATION
sentry-service/sentry-service-client/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java
PRE-CREATION
sentry-service/sentry-service-server/pom.xml PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsSnapshotId.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryVersion.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/PathsImage.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/PermissionsImage.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionBlock.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/GSSCallback.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HMSClient.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HMSFollowerState.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveConnectionFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/KerberosConfiguration.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/ProcessorFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryServiceState.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryState.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/SentryService.html
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/css/sentry.css
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/sentry.png PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/generic/thrift/SentryGenericServiceIntegrationBase.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/generic/thrift/TestAuditLogForSentryGenericService.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericPolicyProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericServiceClient.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/generic/thrift/TestSentryGenericServiceIntegration.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/SentryMiniKdcTestcase.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestAuthorizingDDLAuditLogWithKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestConnectionWithTicketTimeout.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestNotificationHandlerInvoker.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyServiceClient.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerForPoolWithoutKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerLogLevel.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerPubSub.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServerWithoutKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceClientPool.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceFailureCase.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceForPoolWithKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceMetrics.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceWithInvalidMsgSize.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceWithKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithKerberos.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithSSL.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryGMPrivilege.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/entity/TestDbAuditMetadataLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/entity/TestGMAuditMetadataLogEntity.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactory.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/entity/TestJsonLogEntityFactoryGM.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/util/TestCommandUtil.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestCounterWait.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestLeaderStatusMonitor.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryPrivilege.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServiceForAuthTypeNone.java
3d8bf960267c86c57e0acf9aa7572bf8aff67735
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/SentryStateBankTestHelper.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/SentryWebMetricParser.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateInitializer.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestSentryStateBank.java
PRE-CREATION
sentry-service/sentry-service-server/src/test/resources/cacerts.jks
PRE-CREATION
sentry-service/sentry-service-server/src/test/resources/keystore.jks
PRE-CREATION
sentry-service/sentry-service-server/src/test/resources/log4j.properties
PRE-CREATION
Diff: https://reviews.apache.org/r/67093/diff/6/
Changes: https://reviews.apache.org/r/67093/diff/5-6/
Testing
-------
mvn clean install
Thanks,
Anthony Young-Garner
