> On May 31, 2018, 9:20 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 814 (original), 835-836 (patched) > > <https://reviews.apache.org/r/67402/diff/1/?file=2033279#file2033279line835> > > > > Shoult it be better to move this method to the MSentryRole class > > instead? > > > > This would look better: > > > > MSentryPrivilege mSelect = > > mRole.findPrivilege(convertToMSentryPrivilege(tNotAll));
No. findMatchPrivilege is not specific to a role or a user. It is generial function with input of list of privileges, and a privilege to match, and output the matched privilege in the list. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67402/#review204151 ----------------------------------------------------------- On June 4, 2018, 3:29 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67402/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 3:29 a.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2244 > https://issues.apache.org/jira/browse/sentry-2244 > > > Repository: sentry > > > Description > ------- > > When granting privilege to a user or role, sentry does not need to get > individual privilege with specific action from DB again after all its > associated privileges are fetched from DB. We just just find the > corresponding privilege from list to avoid extra query to DB > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5932335 > > > Diff: https://reviews.apache.org/r/67402/diff/2/ > > > Testing > ------- > > test cases in TestSentryStore succeeded > > > Thanks, > > Na Li > >
