> On June 4, 2018, 9:33 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/67440/diff/1/?file=2035073#file2035073line74> > > > > I'm concerned about the parameters types. How is it going to look like > > when user privileges is supported? We would need the > > TAlterSentryUserRequest, right? > > Na Li wrote: > Since the current owner privilege is from event notification, we don't > have some info. Can we have another function with different types of request > and response when formally support user privilege? > > kalyan kumar kalvagadda wrote: > When user privilege is implemented there should be new API added which > takes TAlterSentryUserRequest as input.
We don't have any similar notification when dropping a privilege from the NotificationProcessor. We might a bug there as well. Anyway, the concern I have is the method name related to user privileges and no how we're thinking on granting the owner privileges. We're thinking on replacing the owner privilege in one transaction, how is this going to affect these grant/revoke notifications? - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67440/#review204278 ----------------------------------------------------------- On June 4, 2018, 9:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67440/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 9:04 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: sentry-2158 > https://issues.apache.org/jira/browse/sentry-2158 > > > Repository: sentry > > > Description > ------- > > add function for grant and revoke user privilege in NotificationHandler > > > Diffs > ----- > > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandler.java > 341b85a > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/NotificationHandlerInvoker.java > 39537c2 > > > Diff: https://reviews.apache.org/r/67440/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
