----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67447/#review204335 -----------------------------------------------------------
Code change looks good. Please add unit tests. sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java Lines 223-226 (patched) <https://reviews.apache.org/r/67447/#comment286775> please add comment for this method. - kalyan kumar kalvagadda On June 5, 2018, 12:12 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67447/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 12:12 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Na Li. > > > Bugs: SENTRY-2162 > https://issues.apache.org/jira/browse/SENTRY-2162 > > > Repository: sentry > > > Description > ------- > > This patch implements the API to list user privileges and provide > authorization using user privileges. > It also allows Hive to use the SHOW GRANT USER command when listing the user > privileges. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > fc2427cbf2289f79550c25298ad1f76ac56ae7b4 > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java > 4ba7e801156f38fa7e2eecb03316c2a096c55248 > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java > c964318d93cb7b8ea2724852c871ad5ec5fcfc06 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > 80a634392bf6e9d9d12019bc50e3e4136a9605ff > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > b5ef200c72e48d5d288c167403f1abdd6bca9ce7 > > > Diff: https://reviews.apache.org/r/67447/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
