-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/#review204602
-----------------------------------------------------------




sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
Line 236 (original), 236 (patched)
<https://reviews.apache.org/r/67527/#comment287184>

    should you set the entityName as well?


- Na Li


On June 11, 2018, 3:19 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67527/
> -----------------------------------------------------------
> 
> (Updated June 11, 2018, 3:19 p.m.)
> 
> 
> Review request for sentry and Na Li.
> 
> 
> Bugs: SENTRY-2262
>     https://issues.apache.org/jira/browse/SENTRY-2262
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 
> servers.
> 
> 
> Diffs
> -----
> 
>   
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
>  4e605ae78ffebe54349c4e27c6bc73ee25dd85b6 
> 
> 
> Diff: https://reviews.apache.org/r/67527/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Reply via email to