> On June 18, 2018, 9:31 p.m., Sergio Pena wrote:
> > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
> > Line 243 (original), 258 (patched)
> > <https://reviews.apache.org/r/67134/diff/9/?file=2042189#file2042189line262>
> >
> > Why is the users parameter removed? It is part of the 'grant role to
> > user' functionality.
Sergio, that is the older method without users parameter. The new one which has
the users paramenter is below. Not sure why revision board is showing that is
different:
SentryObjectPrivileges listPrivilegsbyAuthorizable(
String requestorUserName, Set<List<? extends Authorizable>> authorizables,
Set<String> groups, Set<String> users, ActiveRoleSet roleSet) throws
SentryUserException;
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67134/#review204955
-----------------------------------------------------------
On June 18, 2018, 7:08 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67134/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 7:08 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and
> Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently Sentry doesn't support Hive command to show privileges on
> authorizables without mentioning any role or user name
>
>
> Diffs
> -----
>
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
> 23246c903
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
> f0b4b4466
>
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
> 2e3fd7f36
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryObjectPrivileges.java
> PRE-CREATION
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
> 6f38ed20d
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
> 45dce0e7c
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestShowGrants.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67134/diff/9/
>
>
> Testing
> -------
>
> $ mvn -f sentry-binding/pom.xml test
> $ mvn -f sentry-provider/pom.xml test
>
>
> Thanks,
>
> Arjun Mishra
>
>
