----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/#review205034 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 1126 (patched) <https://reviews.apache.org/r/67648/#comment287915> Still I don't understand this if. If an entity is removed and left the privilege stale, then the persistPrivilge() will not be called right? Because this if only calls it if either users or roles are not empty. - Sergio Pena On June 19, 2018, 10:22 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67648/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 10:22 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2251 > https://issues.apache.org/jira/browse/SENTRY-2251 > > > Repository: sentry > > > Description > ------- > > User privileges granted to user on tables/databases should be removed when > the authorizable is dropped. > User privileges granted to user on tables/databases should be updated when > the authorizable are renamed. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > f0e373a9aa5342d1b507e8b192cfdbc444242227 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > c056446262ddcf61db307eafbb785eac42973c80 > > > Diff: https://reviews.apache.org/r/67648/diff/2/ > > > Testing > ------- > > Made sure all the existing tests pass. Also updated tests to cover new use > cases added by this patch. > > > Thanks, > > kalyan kumar kalvagadda > >
