----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/ -----------------------------------------------------------
(Updated June 22, 2018, 4:31 p.m.) Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Changes ------- Addressed all comments. Repository: sentry Description ------- This change makes SentryStore pluggable, and adds an interface SentryStoreIface. It also converts all the call sites to program to the interface instead of the implementation. To make SentryStore pluggable, we also introduce a new config sentry.service.sentrystore that can be used to accept a plugin of a different implementation of SentryStore. The config defaults to the existing org.apache.sentry.provider.db.service.persistent.SentryStore Added interface stability annotations to make it known that this interface provides no guarantees across any levels of release granularity. Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java a4e69b9 sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java 777c262 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java b2e45f9 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java fd0d87b sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java 7cd2c31 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java ef0203f sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessorFactory.java 1ad9a02 sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java 6ff3c82 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java 311b020 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 232a979 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 5aef620 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java fd209b7 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java e27e1db sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java 4e2290b sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/classification/InterfaceAudience.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java 42770df sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java a771f4b sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java 6075e3f sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 27b8876 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/DynamicProxy.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java 93cc34f sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/ProcessorFactory.java 2a48c63 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java b9a0563 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java d92ec21 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java a9e8230 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java 0c66dd2 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 51048bc sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java ebc8c31 Diff: https://reviews.apache.org/r/67658/diff/2/ Changes: https://reviews.apache.org/r/67658/diff/1-2/ Testing ------- Made sure all the existing tests pass (all PreCommit tests pass) Thanks, Fahd Siddiqui
