----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67749/#review205451 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java Line 100 (original), 100 (patched) <https://reviews.apache.org/r/67749/#comment288370> I really not like to pass Configuration objects between classes as it does not explicitly specify why we needed it. In this case, we only need it to get the server name. We created the SentryHmsEvent to abstract these kind of cases, so we could keep it that way if we pass the server name and avoid passing the configuration. You can get the server name from the constroctor of SentrySyncHMSNotificationsPostEventListenre where the configuratoin is passed as a parameter, and just pass the server string to the SentryHmsEvent. - Sergio Pena On June 27, 2018, 3:57 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67749/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 3:57 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2280 > https://issues.apache.org/jira/browse/sentry-2280 > > > Repository: sentry > > > Description > ------- > > The required fields in TSentryHmsEventNotification and > TSentryHmsEventNotificationResponse are not filled, which caused the request > from client to sever to be null. And the response from server to client is > null. Change the data structure to make owner info optional, and fill other > required fields properly > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java > 42be3c3 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > f7d1b07 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java > 8e79cac > > sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java > 75b2799 > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > 56aedcb > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 3927150 > > > Diff: https://reviews.apache.org/r/67749/diff/3/ > > > Testing > ------- > > Manually trace into code and verfied that now the server receives request and > client receiveds response correctly > > > Thanks, > > Na Li > >
