> On June 27, 2018, 7:18 p.m., Na Li wrote: > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > > Lines 391 (patched) > > <https://reviews.apache.org/r/67745/diff/3/?file=2046402#file2046402line391> > > > > this is duplicate of line 393. should you remove it?
Good catch. There are several duplicates in other methods. Will fix them - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67745/#review205466 ----------------------------------------------------------- On June 27, 2018, 5:34 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67745/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 5:34 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2273 > https://issues.apache.org/jira/browse/SENTRY-2273 > > > Repository: sentry > > > Description > ------- > > The SentryHiveAuthorizationTaskFactoryImpl class creates all the supported > DDL tasks for authorization in Hive. We need to add the support for the SHOW > GRANT USER as well. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > e58fe86a2 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > e497f8c78 > > > Diff: https://reviews.apache.org/r/67745/diff/3/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
