----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67803/#review205797 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2786-2797 (patched) <https://reviews.apache.org/r/67803/#comment288712> I agree that there is an issue with renaming privilege with grant option set. I don't think performing renamePrivilegeCore twice is an optimal solution for this. At the same time I don't want to block this patch for it as this patch is not adding tests for this scenario. I prefer to create seperate jira for this and not include changes to fix the rename privilege in this patch. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java Lines 283-288 (patched) <https://reviews.apache.org/r/67803/#comment288697> Using same variable "statement" for both admin and non admin operations is confusing. In this line here statement is "hiveServer2.createConnection(admin, admin); but later in this method it is updated with return value of hiveServer2.createConnection(USER1_1, USER1_1); It makes it difficult to understand admin and non admin operation. You can use different variable for admin operations. This comment applies to all the tests. - kalyan kumar kalvagadda On July 5, 2018, 9:14 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67803/ > ----------------------------------------------------------- > > (Updated July 5, 2018, 9:14 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2247 > https://issues.apache.org/jira/browse/sentry-2247 > > > Repository: sentry > > > Description > ------- > > add test case to verify the owner privileges are added at db and table > creation. Some testing cases have to be ignore until sentry-2291 is done > > Fix multiple issues found by the new test cases: > 1. The server name of owner privilege was not set at server side > 2. When dropping privilege, if a privilege has no role, it is not dropped > 3. When dropping privilege, if it has grant option being true, it is not > dropped. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 98f2e29 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ff0b4c0 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > 14a0fd8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > 100219b > > > Diff: https://reviews.apache.org/r/67803/diff/5/ > > > Testing > ------- > > test cases in TestOwnerPrivileges and TestOwnerPrivilegesWithGrantOption > passed > > > Thanks, > > Na Li > >
