> On July 9, 2018, 5:53 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > > Line 20 (original), 20 (patched) > > <https://reviews.apache.org/r/67846/diff/2/?file=2053693#file2053693line20> > > > > Shouldn't this be done automatically by the shading plugin?
No because it's a transitive dependency. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/#review205860 ----------------------------------------------------------- On July 9, 2018, 7:17 p.m., Steve Moist wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67846/ > ----------------------------------------------------------- > > (Updated July 9, 2018, 7:17 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Excluding conflicting dependencies and shading io.dropwizard.metrics. > > > Diffs > ----- > > pom.xml 488426593 > sentry-binding/sentry-binding-kafka/pom.xml 239eeba5f > sentry-dist/src/license/THIRD-PARTY.properties b39e1b6ca > sentry-dist/src/main/assembly/bin.xml 72773df1e > sentry-hdfs/sentry-hdfs-dist/pom.xml 93943157d > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > 81c614a34 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > 3532ef33d > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java > 8d6713acd > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java > b87d29040 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > 0cd405b54 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHdfsMetricsUtil.java > 3bf300bef > sentry-provider/sentry-provider-db/pom.xml a8a15bfb1 > sentry-service/sentry-service-server/pom.xml a103c1e25 > sentry-tests/sentry-tests-solr/pom.xml db33ee9f4 > sentry-tests/sentry-tests-sqoop/pom.xml e280c9eb5 > > > Diff: https://reviews.apache.org/r/67846/diff/3/ > > > Testing > ------- > > > Thanks, > > Steve Moist > >
