-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67912/
-----------------------------------------------------------
(Updated July 16, 2018, 5:56 p.m.)
Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, and Sergio
Pena.
Bugs: SENTRY-2310
https://issues.apache.org/jira/browse/SENTRY-2310
Repository: sentry
Description
-------
If the communication between sentry and HMS goes down for any reason while
sentry is fetching full update from HMS, SentryHMSClient in HMSFollower would
be left with a reference to closed socket. As sentry is not handling the
failure and closing the SentryHMSClient, it continues using the same
SentryHMSClient. This will result in "java.net.SocketException: Broken pipe" as
the client tries to write on socket that is closed.
Fix: Close the SentryHMSClient when there is an exception. Drawback with this
approach is that we need to make sure that this is done when ever new API's are
added to SentryHMSClient.
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
9d1a92f185ab9ddf5efa8f1b51ff054cf2cfbcd3
Diff: https://reviews.apache.org/r/67912/diff/2/
Changes: https://reviews.apache.org/r/67912/diff/1-2/
Testing
-------
Made sure that all the existing tests passed.
Thanks,
kalyan kumar kalvagadda
