----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68025/#review206399 -----------------------------------------------------------
Please add a unit test in TestHMSFollower to get full test coverage of your change. sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java Lines 54 (patched) <https://reviews.apache.org/r/68025/#comment289336> There is apace between "-" and "1". Please correct it. Why not consider o as the default value? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java Lines 74 (patched) <https://reviews.apache.org/r/68025/#comment289337> You useed fetch_size and also used fetch_depth. Please be in-line by changing one of them. - kalyan kumar kalvagadda On July 23, 2018, 9:50 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68025/ > ----------------------------------------------------------- > > (Updated July 23, 2018, 9:50 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2324 > https://issues.apache.org/jira/browse/SENTRY-2324 > > > Repository: sentry > > > Description > ------- > > Currently sentry fetches all notifications greater than latest notification > Id from HMS. With this sentry will only fetch notifications over a configured > depth > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > a9afb151a > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > 7667c47d5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > 8490d7ac2 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java > 83a1becd4 > > > Diff: https://reviews.apache.org/r/68025/diff/1/ > > > Testing > ------- > > $ mvn -f sentry-service/sentry-service-server/pom.xml test > > > Thanks, > > Arjun Mishra > >
