> On July 24, 2018, 5:42 p.m., kalyan kumar kalvagadda wrote:
> > Arjun,
> >
> > I know the diff the big but the actual change is just refactoring certain
> > enum names and variable names. It would be easy if you summrize the
> > chanages.
Kalyan,
Below is the summary.
1) Thrift changes - Renamed TPrivilegeEntity, TPrivilegeEntityType,
TSentryObjectOwnerType to TPrivilegePrincipal, TPrivilegePrincipalType, and
TSentryPrincipalType. The other affected references
a) TPrivilegePrincipal AFFECTED TPrivilegeChanges, PermissionsUpdate,
SentryPermissions, UpdateableAuthzPermissions, DBUpdateForwarder,
PermImageRetreiver, SentryPlugin, NotificationsProcessor, PermissionsImage,
SentryStore and all relevant test classes
b) TPrivilegePrincipalType AFFECTED SentryPermissions,
UpdateableAuthzPermissions, SentryPlugin, NotificationProcessor, SentryStore
and relevant test classes
c) TSentryPrincipalType AFFECTED SentryHMSEvent, SentryPolicyServiceClient,
TSentryHMSEventNotification, TSentryPrincipal, SentryPolicyStoreProcessor
2) Renamed PrivilegeEntity to PrivilegePrincipal
a)This change AFFECTED MSentryPrivilege, MSentryRole, SentryStore
Let me know if this is sufficient
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68028/#review206402
-----------------------------------------------------------
On July 24, 2018, 12:10 a.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68028/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 12:10 a.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and
> Sergio Pena.
>
>
> Bugs: SENTRY-2316
> https://issues.apache.org/jira/browse/SENTRY-2316
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2252 added code to put the role and user types as categories. These
> are called 'entities' or 'entity' for the singular. However, Hive uses
> 'principal'. Like PrincipalType.ROLE and PrincipalType.USER. And change
> EntityName to PrincipalName. The changes should cover both java class and
> thrift generated types.
>
> We should use the same naming convention of the ROLE and USER category to
> avoid confusions.
>
>
> Diffs
> -----
>
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java
> ef63a34df
>
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java
> e261fc6f6
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryOwnerInfo.java
> ee4fce56e
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java
> c1beaed0a
>
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java
> abcf3ca5d
>
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeEntity.java
> 85f814751
>
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeEntityType.java
> ac44c1f91
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PermissionsUpdate.java
> 5691933fe
>
> sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift
> 61582cd0e
>
> sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestPermissionUpdate.java
> 8bd9d439b
>
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java
> c162ec19c
>
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
> 761c760f2
>
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryPermissions.java
> f0ca787bb
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
> 065adb74f
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
> 2a6750418
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java
> 6cb787bb7
>
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDeltaRetriever.java
> d7bc74834
>
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java
> b86136d6f
>
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java
> 845c1377d
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TListSentryPrivilegesRequest.java
> 01e52300e
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java
> fe891252e
>
> sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryObjectOwnerType.java
> 6b540b882
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
> 1a8034b10
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
> 07da2ba3c
>
> sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift
> f238748cc
>
> sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyServiceClientDefaultImpl.java
> c7145848a
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
> 2efc8cf9c
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
> e5eb4c403
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java
> 74213afe2
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java
> 6e44c79df
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
> 01899bf39
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/PermissionsImage.java
> 4a02db2a6
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/PrivilegeEntity.java
> 3f7ba9783
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> 4f7bdbde1
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java
> 44431486d
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
> 3475624e3
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java
> 3b58de37d
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
> 6a84b0521
>
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
> d33ae2608
>
>
> Diff: https://reviews.apache.org/r/68028/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
