> On Aug. 8, 2018, 2:48 p.m., Na Li wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java > > Line 66 (original), 72 (patched) > > <https://reviews.apache.org/r/68264/diff/1/?file=2070013#file2070013line74> > > > > should we use try/catch here? So if one handler fails to handle the > > signal, the next handlers can still process the singnal?
Yeah this makes sense. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68264/#review206992 ----------------------------------------------------------- On Aug. 7, 2018, 4 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68264/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 4 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2335 > https://issues.apache.org/jira/browse/SENTRY-2335 > > > Repository: sentry > > > Description > ------- > > This changes the SigUtil class to allow for multiple signal handler functions > to be defined and executed per signal. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SigUtils.java > 1f16e1435dde850d651b9b9f5ad8e6253269d106 > > > Diff: https://reviews.apache.org/r/68264/diff/1/ > > > Testing > ------- > > Tested with unit tests and manual testing > > > Thanks, > > Brian Towles > >
