----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68271/#review207007 -----------------------------------------------------------
Ship it! Ship It! - Na Li On Aug. 8, 2018, 9:37 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68271/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2018, 9:37 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2337 > https://issues.apache.org/jira/browse/SENTRY-2337 > > > Repository: sentry > > > Description > ------- > > This is not correct behavior as sentry admin users have privileges to > grant/revoke privileges need not have privileges to view/update the HMS data. > They need explicit privileges to do so. > > > > user belonging to sentry admin groups need owner privileges for that objects > that they own. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 61f9168b1970144dbf0b7a7378f2d25e70f1761d > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5644181af6a631120bdcd097e4e390a652106dc0 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 164188bc56e2d0332b8e9608ed163b22ec3bb08e > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > e2e8c399cae125c263ac4310f6bc3f6b42da21d9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > 2ecf8feb05d9f7807681508cd4fbe1b0982760e4 > > > Diff: https://reviews.apache.org/r/68271/diff/1/ > > > Testing > ------- > > Updated the tests accordingly. > > > Thanks, > > kalyan kumar kalvagadda > >
