----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68273/#review207026 -----------------------------------------------------------
Ship it! Looks Good. - kalyan kumar kalvagadda On Aug. 9, 2018, 2:23 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68273/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 2:23 a.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2313 > https://issues.apache.org/jira/browse/sentry-2313 > > > Repository: sentry > > > Description > ------- > > only user with "all with grant option" on database or its parent issue the > command "alter database set owner". Since HIVE-18031 is not in the hive > version integrated with Sentry, some code is commented out with "TODO: Enable > once HIVE-18031 is available" or "Enable the test once HIVE-18031 is in the > hiver version integrated with Sentry" > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 09bd9b5 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > d976512 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java > 0dd8bf1 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > 080eda8 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 61f9168 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > 2ecf8fe > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java > 4de7475 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > f5e4db8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart1.java > f3edae2 > > > Diff: https://reviews.apache.org/r/68273/diff/1/ > > > Testing > ------- > > tested the ignored test cases on private build that has HIVE-18031 ported. > > > Thanks, > > Na Li > >
