----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68302/#review207160 -----------------------------------------------------------
Can you explain the solution approach that you have taken in your patch to address the issue? That way it will be easy to go over the patch. - kalyan kumar kalvagadda On Aug. 10, 2018, 9:41 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68302/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2018, 9:41 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2342 > https://issues.apache.org/jira/browse/sentry-2342 > > > Repository: sentry > > > Description > ------- > > check if sentry version is compatible with DB schema version or not instead > of checking if they are equal. This allows multi-version multi-clusters share > the same DB > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > 0d4f26c > > sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentrySchemaTool.java > 4c3df20 > > sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentrySchemaTool.java > 84c2484 > > > Diff: https://reviews.apache.org/r/68302/diff/1/ > > > Testing > ------- > > TestSentrySchemaTool passed > > > Thanks, > > Na Li > >
