> On Aug. 17, 2018, 4:57 a.m., Na Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > > Line 890 (original), 894 (patched) > > <https://reviews.apache.org/r/68394/diff/1/?file=2073600#file2073600line894> > > > > should you set it to be Null when OwnerPrivilegeEnabled == false since > > "SentryOwnerPrivilegeType SENTRY_DB_POLICY_STORE_OWNER_AS_PRIVILEGE_DEFAULT > > = SentryOwnerPrivilegeType.ALL;"?
Done. I changed the default to be NONE to avoid incompatibilities between 2.0 and 2.1. I also set the value to NONE if the OwnerPrivilegeEnabled is false. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68394/#review207476 ----------------------------------------------------------- On Aug. 17, 2018, 2:47 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68394/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 2:47 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2355 > https://issues.apache.org/jira/browse/sentry-2355 > > > Repository: sentry > > > Description > ------- > > This patch replaces the owner configurations: > - sentry.enable.owner.privileges = [true,false] > - sentry.enable.owner.privileges.with.grant = [true,false] > > to: > - sentry.db.policy.store.owner.as.privilege = [none,all,all_with_grant] > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 9a2091ae195bea3dc1ef8f966a598459e8446d7c > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 07221afaa2c3de3c723c7282da593e55353e76be > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > 94dbd70c002de871dbc53d463d537798733ef99b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > becdc52631d348fe4ddc650dab64abd1370c2469 > > > Diff: https://reviews.apache.org/r/68394/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
