----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68452/#review207752 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3001 (original), 3007 (patched) <https://reviews.apache.org/r/68452/#comment291255> why do you change exception type? SentryInvalidInputException is derived from SentryUserException - Na Li On Aug. 22, 2018, 10:40 a.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68452/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 10:40 a.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2359 > https://issues.apache.org/jira/browse/SENTRY-2359 > > > Repository: sentry > > > Description > ------- > > Added code changes to look for owner privilege for roles and users while > authorizing a privilege grant request. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 1decef2bafb98cdeb98f7d570eecdcc705f8249f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java > b3d98cb319916b2272c10ea0b39d91d4b118df3e > > > Diff: https://reviews.apache.org/r/68452/diff/3/ > > > Testing > ------- > > Added new test to verify the same and also made sure that all the existing > tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
