-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207759
-----------------------------------------------------------




sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Line 431 (original), 456 (patched)
<https://reviews.apache.org/r/67934/#comment291261>

    It seems your code is not update to date.
    
    We don't have function verifyTablePrivilegeExistForUser, instead we have 
verifyTableOwnerPrivilegeExistForPrincipal now.


- Na Li


On Aug. 15, 2018, 6:16 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 6:16 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2233
>     https://issues.apache.org/jira/browse/SENTRY-2233
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add tests to verify owner privileges are synchronized to HDFS ACL's where 
> owner can be a role/user.
> 
> 
> Diffs
> -----
> 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
>  e730dd583ac8521ffae4576c63226cabd35cabcc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
>  9535dee395162687de2a4b4354f75080a5562635 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
>  0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
>  f70b6abd3d95a2b2e5995648c112600108421652 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
>  8a1021426d72eb5f282975963357a553d79d0a48 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  c8fc019ec35164b704c1570553d6fc6d561ff525 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  9b4f4da0c89e00d002d95956521d014ad6c99ddc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
>  061900a4bd4d53532957e4fccddd5054c6022a0b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
>  7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 
> 
> 
> Diff: https://reviews.apache.org/r/67934/diff/2/
> 
> 
> Testing
> -------
> 
> Added tests to verify HDFS ACL for owner privileges.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Reply via email to