----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68487/#review207819 -----------------------------------------------------------
sentry-solr/solr-sentry-handlers/pom.xml Lines 94-103 (patched) <https://reviews.apache.org/r/68487/#comment291344> If the dependency is listed in parent pom file, it is good to have the exclusion in the parent pom file instead of child pom files. This comment applies to other places as well. - kalyan kumar kalvagadda On Aug. 23, 2018, 1:34 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68487/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 1:34 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2366 > https://issues.apache.org/jira/browse/sentry-2366 > > > Repository: sentry > > > Description > ------- > > Sentry uses Jackson 1.8.8, but there are other versions of jackson jars that > are brought by transitive dependencies. Even if this is not conflicting, we > should harmonize the version that Sentry should use for Jackson. > > > Diffs > ----- > > pom.xml dcf107680c3b395819043136bcc6e179a60ada35 > sentry-binding/sentry-binding-hbase-indexer/pom.xml > d50acfec954acf8e8d9682425122039e6f5a2724 > sentry-binding/sentry-binding-hive-follower/pom.xml > 5f8a5afb479b783d027a005ea8f72590445b8386 > sentry-binding/sentry-binding-hive/pom.xml > 09d75f7de961aa0d3d03c875fb896504c0c72a3e > sentry-binding/sentry-binding-solr/pom.xml > f08669994aa6d058fc9c92e6a8b576063602cc95 > sentry-hdfs/sentry-hdfs-common/pom.xml > 2bfb76d6686324a7a949b01bfb7557fac4c2b89d > sentry-provider/sentry-provider-db/pom.xml > bfe91d7e1f21b7fee73a9ccb80229eccae4531aa > sentry-service/sentry-service-server/pom.xml > c835292790dbc31b164dc1668c860a3f58aeda6b > sentry-solr/solr-sentry-handlers/pom.xml > accd581263447578724b5b7d7699f9e42efed083 > sentry-tests/sentry-tests-hive/pom.xml > c753acf31580d9ff553da35076a523552b54b244 > sentry-tests/sentry-tests-kafka/pom.xml > 03bc57453922d99c45f8e2bca8bdb532a6115170 > sentry-tests/sentry-tests-solr/pom.xml > cc0969aebadb69e08f830a5a97d95962a3258da3 > > > Diff: https://reviews.apache.org/r/68487/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
