----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68657/#review208414 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Line 1397 (original), 1397 (patched) <https://reviews.apache.org/r/68657/#comment292319> Shouldn't there be a finally block here to stop the timer? - Steve Moist On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68657/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 2:57 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2392 > https://issues.apache.org/jira/browse/sentry-2392 > > > Repository: sentry > > > Description > ------- > > Add some metric statistics to the new SentryPolicyStoreProcessor API that > returns a list of users and roles privileges. This would be good to collect > in order to understand how this API is used. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 008a48efc0b1a2a8703a301c85cf0068dd171f38 > > > Diff: https://reviews.apache.org/r/68657/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
