----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68689/#review208525 -----------------------------------------------------------
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 31 (patched) <https://reviews.apache.org/r/68689/#comment292509> Can you add a testing case for following upgrade order 1.7.0-to-1.8.0, 1.8.0-to-1.9.0, 1.8.0-to-2.0.0, 2.0.0-to-2.1.0, 1.9.0-to-2.1.0 from 1.7.0 to 2.1.0 has two pathes, and you may get one of them. Using visited list to control which one to return in search function sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 145 (patched) <https://reviews.apache.org/r/68689/#comment292507> fix comment sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 145 (patched) <https://reviews.apache.org/r/68689/#comment292508> fix comment sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 151 (patched) <https://reviews.apache.org/r/68689/#comment292510> check from 1.9.0 to 2.0.0 returns nothing sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 168 (patched) <https://reviews.apache.org/r/68689/#comment292511> from multiVersionsOrder, you have two paths from 1.7.0 to 2.0.0. returning path of 1.7.0 to 2.0.0 directly should also be considered as correct in test. sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java Lines 174 (patched) <https://reviews.apache.org/r/68689/#comment292512> should check no path for 1.9.0 to 2.0.0 - Na Li On Sept. 11, 2018, 5:08 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68689/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2018, 5:08 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: sentry-2398 > https://issues.apache.org/jira/browse/sentry-2398 > > > Repository: sentry > > > Description > ------- > > Add support on the SentrySchemaTool to allow more complex upgrade scenarios > where the order of the upgrades found in the upgrade.order.<db> file is not > the correct order. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > 0d4f26c6d47991313794d250e5c232262c7559b5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryUpgradeOrder.java > PRE-CREATION > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryUpgradeOrder.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68689/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
