> On Sept. 20, 2018, 2:20 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > > Lines 725 (patched) > > <https://reviews.apache.org/r/68779/diff/1/?file=2090407#file2090407line725> > > > > This line fails immediatly, but instead of throwing a test case error, > > it goes to the finally() clause and finish with the test successfully. > > Na Li wrote: > why do you think this fails? It should work.
It failed to me while running the debug. The test does not fail, but the line jumps directly to the finally() clause. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68779/#review208796 ----------------------------------------------------------- On Sept. 20, 2018, 4:24 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68779/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 4:24 a.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2409 > https://issues.apache.org/jira/browse/sentry-2409 > > > Repository: sentry > > > Description > ------- > > add code to get table name and DB name based on token children size > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 6731d1a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > 55a79ee > > > Diff: https://reviews.apache.org/r/68779/diff/1/ > > > Testing > ------- > > unit tests in TestOwnerPrivileges passed > > > Thanks, > > Na Li > >
