----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/#review208814 -----------------------------------------------------------
sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/common/TestSentryServiceUtil.java Lines 53 (patched) <https://reviews.apache.org/r/68788/#comment293018> You can use Assert.fail("ALL, SELECT and INSERT privileges should be permitted"); It is more intuitive. sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/common/TestSentryServiceUtil.java Lines 60 (patched) <https://reviews.apache.org/r/68788/#comment293019> same thing Assert.fail() sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 264 (patched) <https://reviews.apache.org/r/68788/#comment293020> Can you add e2e test case for this? To make sure this is called when client requests some privileges not supported? - Na Li On Sept. 20, 2018, 8:28 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68788/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2018, 8:28 p.m.) > > > Review request for sentry. > > > Bugs: sentry-2413 > https://issues.apache.org/jira/browse/sentry-2413 > > > Repository: sentry > > > Description > ------- > > Add a new configuration 'sentry.db.explicit.grants.permitted' that accepts a > comma-separated list of privileges that can be granted by Sentry DB clients. > If the value is empty, then any privilege can be granted as it works normally > (this is the default behavior). > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > adc1947a1 > > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java > 8cdbde4f9 > > sentry-service/sentry-service-api/src/test/java/org/apache/sentry/api/common/TestSentryServiceUtil.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 3a9623b46 > > > Diff: https://reviews.apache.org/r/68788/diff/1/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Sergio Pena > >
